Re: [PATCH 08/17] mkfs: getbool is redundant

[Dave Chinner <david@xxxxxxxxxxxxx>]

On Fri, Jun 26, 2015 at 01:17:01PM -0400, Brian Foster wrote:
> On Fri, Jun 19, 2015 at 01:01:57PM +0200, Jan ÅulÃk wrote:
> > From: Dave Chinner <dchinner@xxxxxxxxxx>
> > 
> > getbool() can be replaced with getnum_checked with appropriate
> > min/max values set for the boolean variables.
> > 
> > Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
> > Signed-off-by: Jan ÅulÃk <jtulak@xxxxxxxxxx>
....
> >             },
> >             { .index = R_NAME,
> > +             .defaultval = SUBOPT_NEEDS_VAL,
> >             },
> >             { .index = R_NOALIGN,
> > +             .defaultval = SUBOPT_NEEDS_VAL,
> 
> Not sure about this one, either. There's no value according to the man
> page.

Keep in mind one of the reasons for doing this cleanup is to make
all the options consistent in their handling. i.e. all boolean
options will take a 0 or 1 value, regardless of whether they
currently require it or not.

i.e. this patchset changes the mkfs CLI interface to fix
inconsistencies that have crept in over the years....

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx