| To: | xfs@xxxxxxxxxxx |
|---|---|
| Subject: | Re: [PATCH v3] xfs: extent size hints can round up extents past MAXEXTLEN |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Wed, 27 May 2015 11:56:05 +1000 |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1432686984-15195-1-git-send-email-david@xxxxxxxxxxxxx> |
| References: | <1432686984-15195-1-git-send-email-david@xxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Wed, May 27, 2015 at 10:36:24AM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
>
> This results in BMBT corruption, as seen by this test:
....
> - if ((temp = (align_alen % extsz))) {
> - align_alen += extsz - temp;
> - }
> + while (align_alen > MAXEXTLEN)
> + align_alen -= extsz;
> + ASSERT(align_alen <= MAXEXTLEN);
FYI, this bit is the only difference in this version - it fixes the
test case that Brian pointed out that still didn't work properly.
Cheers,
Dave.
--
Dave Chinner
david@xxxxxxxxxxxxx
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | 6ææå-èèééåçåFTP, åææ |
|---|---|
| Next by Date: | [PATCH v2 2/5] xfs_repair: better checking of v5 metadata fields, Darrick J. Wong |
| Previous by Thread: | [PATCH v3] xfs: extent size hints can round up extents past MAXEXTLEN, Dave Chinner |
| Next by Thread: | Re: [PATCH v3] xfs: extent size hints can round up extents past MAXEXTLEN, Brian Foster |
| Indexes: | [Date] [Thread] [Top] [All Lists] |