On Fri, May 15, 2015 at 08:51:29AM +0800, Wang Sheng-Hui wrote:
>
>
> On 2015å05æ01æ 16:11, Wang Sheng-Hui wrote:
> > _rename_tests() records the 'flags' arg but doesn't pass it to
> > _rename_tests_source_dest() in old code, thus any 'flags' to
> > renameat2 is missed. Fix the missing.
> >
> > Signed-off-by: Wang Sheng-Hui <shhuiw@xxxxxxxxxxx>
> > ---
> > common/renameat2 | 5 +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/common/renameat2 b/common/renameat2
> > index a335169..df2df2e 100644
> > --- a/common/renameat2
> > +++ b/common/renameat2
> > @@ -78,6 +78,7 @@ _rename_tests_source_dest()
> > local source=$1
> > local dest=$2
> > local options=$3
> > + local flags=$4
> >
> > for stype in none regu symb dire tree; do
> > for dtype in none regu symb dire tree; do
> > @@ -107,11 +108,11 @@ _rename_tests()
> > local flags=$2
> >
> > #same directory renames
> > - _rename_tests_source_dest $testdir/src $testdir/dst "samedir "
> > + _rename_tests_source_dest $testdir/src $testdir/dst "samedir "
> > $flags
> >
> > #cross directory renames
> > mkdir $testdir/x $testdir/y
> > - _rename_tests_source_dest $testdir/x/src $testdir/y/dst "crossdir"
> > + _rename_tests_source_dest $testdir/x/src $testdir/y/dst "crossdir"
> > $flags
> > rmdir $testdir/x $testdir/y
> > }
> >
> >
>
> Any comments?
You can send xfstests patch to fstests@xxxxxxxxxxxxxxx next time.
Thanks,
Eryu
|