| To: | Christoph Hellwig <hch@xxxxxx> |
|---|---|
| Subject: | Re: [PATCH 5/6] xfs: move non-inline symlinks to the pagecache |
| From: | Al Viro <viro@xxxxxxxxxxxxxxxxxx> |
| Date: | Sat, 25 Apr 2015 22:05:20 +0100 |
| Cc: | Dave Chinner <david@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20150425183247.GA30562@xxxxxx> |
| References: | <1429816064-10033-1-git-send-email-hch@xxxxxx> <1429816064-10033-6-git-send-email-hch@xxxxxx> <20150423222942.GK15810@dastard> <20150425141612.GA4153@xxxxxx> <20150425145728.GE889@xxxxxxxxxxxxxxxxxx> <20150425183247.GA30562@xxxxxx> |
| Sender: | Al Viro <viro@xxxxxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Sat, Apr 25, 2015 at 08:32:47PM +0200, Christoph Hellwig wrote: > On Sat, Apr 25, 2015 at 03:57:28PM +0100, Al Viro wrote: > > > Note that caching the symlink in a kmalloc'ed buffer might be > > > more efficient than the pagecache for most cases anyway. > > > > Hmm... When would you free the sucker? > > final iput. Similar design to the generic ACL cache. Except that in this case you have to deal with the cases when it should _not_ be freed in ->evict_inode() (and doing that in generic code is right out). I'm not sure it will be simpler that way, actually... |
| Previous by Date: | donation for you, click reply for more info, Quan (Le Hoang Quan) |
|---|---|
| Next by Date: | Personal, Taofik |
| Previous by Thread: | Re: [PATCH 5/6] xfs: move non-inline symlinks to the pagecache, Christoph Hellwig |
| Next by Thread: | [PATCH 6/6] xfs: optimize inline symlinks, Christoph Hellwig |
| Indexes: | [Date] [Thread] [Top] [All Lists] |