Re: [PATCH] xfs: disallow ro->rw remount on norecovery mount

[Dave Chinner <david@xxxxxxxxxxxxx>]

On Thu, Mar 26, 2015 at 03:03:30PM -0500, Eric Sandeen wrote:
> There's a bit of a loophole in norecovery mount handling right
> now: an initial mount must be readonly, but nothing prevents
> a mount -o remount,rw from producing a writable, unrecovered
> xfs filesystem.
> 
> It might be possible to try to perform a log recovery when this
> is requested, but I'm not sure it's worth the effort.  For now,
> simply disallow this sort of transition.
> 
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>

Good catch.

Shouldn't this also check for a ro block device, and disallow the
rw remount if the block dev is ro?

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx