| To: | Jan Kara <jack@xxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 5/5] xfs: Correctly lock inode when removing suid and security marks |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Wed, 4 Mar 2015 08:34:50 +1100 |
| Cc: | Al Viro <viro@xxxxxxxxxxxxxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1425379119-3773-6-git-send-email-jack@xxxxxxx> |
| References: | <1425379119-3773-1-git-send-email-jack@xxxxxxx> <1425379119-3773-6-git-send-email-jack@xxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Tue, Mar 03, 2015 at 11:38:39AM +0100, Jan Kara wrote: > Currently XFS calls file_remove_privs() without holding i_mutex. This is > wrong because that function can end up messing with file permissions and > security xattrs for which we need i_mutex held. > > Fix the problem by grabbing iolock exclusively when we will need to > change anything in permissions / xattrs. > > Signed-off-by: Jan Kara <jack@xxxxxxx> Looks good. Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx> -- Dave Chinner david@xxxxxxxxxxxxx |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [regression v4.0-rc1] mm: IPIs from TLB flushes causing significant performance degradation., Dave Chinner |
|---|---|
| Next by Date: | Re: [PATCH] [RFC] Implement XFS_IOC_FSBULKSTAT_RANGE ioctl, Dave Chinner |
| Previous by Thread: | [PATCH 5/5] xfs: Correctly lock inode when removing suid and security marks, Jan Kara |
| Next by Thread: | [PATCH] [RFC] Implement XFS_IOC_FSBULKSTAT_RANGE ioctl, Carlos Maiolino |
| Indexes: | [Date] [Thread] [Top] [All Lists] |