Re: [PATCH 2/2] xfs: cancel failed transaction in xfs_fs_commit

xfs

Re: [PATCH 2/2] xfs: cancel failed transaction in xfs_fs_commit_blocks()

To:	Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject:	Re: [PATCH 2/2] xfs: cancel failed transaction in xfs_fs_commit_blocks()
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Mon, 23 Feb 2015 12:48:36 -0800
Cc:	xfs-oss <xfs@xxxxxxxxxxx>, Christoph Hellwig <hch@xxxxxx>
Delivered-to:	xfs@xxxxxxxxxxx
In-reply-to:	<54EB78CB.6050709@xxxxxxxxxxx>
References:	<54EB782F.8020201@xxxxxxxxxx> <54EB78CB.6050709@xxxxxxxxxxx>
User-agent:	Mutt/1.5.23 (2014-03-12)

On Mon, Feb 23, 2015 at 01:00:27PM -0600, Eric Sandeen wrote:
> If xfs_trans_reserve fails we don't cancel the transaction,
> and we'll leak the allocated transaction pointer.
> 
> Spotted by Coverity.

Thanks, looks good.

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 0/2] Fix a couple coverity-spotted issues, Eric Sandeen [PATCH 1/2] xfs: Ensure we have target_ip for RENAME_EXCHANGE, Eric Sandeen Re: [PATCH 1/2] xfs: Ensure we have target_ip for RENAME_EXCHANGE, Christoph Hellwig [PATCH 2/2] xfs: cancel failed transaction in xfs_fs_commit_blocks(), Eric Sandeen Re: [PATCH 2/2] xfs: cancel failed transaction in xfs_fs_commit_blocks(), Christoph Hellwig <=

Previous by Date:	Re: [PATCH] xfs: avoid firstused overflow in attr3 leaf header with 64k blocks, Eric Sandeen
Next by Date:	Re: [PATCH 1/2] xfs: Ensure we have target_ip for RENAME_EXCHANGE, Christoph Hellwig
Previous by Thread:	[PATCH 2/2] xfs: cancel failed transaction in xfs_fs_commit_blocks(), Eric Sandeen
Next by Thread:	[PATCH 0/2] xfs: minor kernel logging updates, Eric Sandeen
Indexes:	[Date] [Thread] [Top] [All Lists]