| To: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 03/17] quota: Add ->quota_{enable,disable} callbacks for VFS quotas |
| From: | Jan Kara <jack@xxxxxxx> |
| Date: | Tue, 20 Jan 2015 18:08:29 +0100 |
| Cc: | Jan Kara <jack@xxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, cluster-devel@xxxxxxxxxx, ocfs2-devel@xxxxxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20150119090248.GC27474@xxxxxxxxxxxxx> |
| References: | <1421412471-4747-1-git-send-email-jack@xxxxxxx> <1421412471-4747-4-git-send-email-jack@xxxxxxx> <20150119090248.GC27474@xxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Mon 19-01-15 01:02:48, Christoph Hellwig wrote:
> On Fri, Jan 16, 2015 at 01:47:37PM +0100, Jan Kara wrote:
> > +EXPORT_SYMBOL(dquot_quota_enable);
>
> > +EXPORT_SYMBOL(dquot_quota_disable);
>
> I can't find any modular users of this (in fact none outside this
> file), so I'd suggest to keep these local.
OK, we can do that. I've exported the functions because in principle
filesystems are free to provide own .quota_enable function and then may
want to call dquot_quota_enable() from there but currently nobody needs
that so let's export them only if there are real users.
Honza
--
Jan Kara <jack@xxxxxxx>
SUSE Labs, CR
|
| Previous by Date: | Re: [PATCH 02/17] quota: Wire up ->quota_{enable,disable} callbacks into Q_QUOTA{ON,OFF}, Jan Kara |
|---|---|
| Next by Date: | Re: [PATCH 05/17] ocfs2: Use generic helpers for quotaon and quotaoff, Jan Kara |
| Previous by Thread: | Re: [PATCH 03/17] quota: Add ->quota_{enable,disable} callbacks for VFS quotas, Christoph Hellwig |
| Next by Thread: | [PATCH 01/17] quota: Split ->set_xstate callback into two, Jan Kara |
| Indexes: | [Date] [Thread] [Top] [All Lists] |