| To: | Jan Kara <jack@xxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 2/5] fs: Fix WARN_ON in inode_set_mask() |
| From: | Al Viro <viro@xxxxxxxxxxxxxxxxxx> |
| Date: | Thu, 4 Dec 2014 14:37:09 +0000 |
| Cc: | linux-fsdevel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, linux-security-module@xxxxxxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1417699659-14284-3-git-send-email-jack@xxxxxxx> |
| References: | <1417699659-14284-1-git-send-email-jack@xxxxxxx> <1417699659-14284-3-git-send-email-jack@xxxxxxx> |
| Sender: | Al Viro <viro@xxxxxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Thu, Dec 04, 2014 at 02:27:36PM +0100, Jan Kara wrote: > WARN_ON in inode_set_mask() warns if we don't clear all bits we are > setting instead of reverse - warning when caller requests setting and > clearing of the same bit. WTF? 'mask' is "all bits we are asked to modify", 'flags' - "the values to put into those bits". Have you even looked at the callers, let alone tested it? |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH v6 2/10] xfs: Add support FALLOC_FL_INSERT_RANGE for fallocate, Brian Foster |
|---|---|
| Next by Date: | [PATCH] xfs: initialize log buf I/O completion wq on log alloc, Brian Foster |
| Previous by Thread: | [PATCH 2/5] fs: Fix WARN_ON in inode_set_mask(), Jan Kara |
| Next by Thread: | Re: [PATCH 2/5] fs: Fix WARN_ON in inode_set_mask(), Jan Kara |
| Indexes: | [Date] [Thread] [Top] [All Lists] |