Re: [PATCH 2/2] xfs: move type conversion functions to xfs_dir.h

[Dave Chinner <david@xxxxxxxxxxxxx>]

On Tue, Dec 02, 2014 at 03:36:26AM -0800, Christoph Hellwig wrote:
> On Tue, Dec 02, 2014 at 10:18:03AM +1100, Dave Chinner wrote:
> > From: Dave Chinner <dchinner@xxxxxxxxxx>
> > 
> > These are currently considered private to libxfs, but they are
> > widely used by the userspace code to decode, walk and check
> > directory structures. Hence they really form part of the external
> > API and as such need to bemoved to xfs_dir2.h.
> 
> Lokos good, but why do we need the additional includes in various files?

Because the conversion functions have a dependency on the struct
xfs_da_geometry definition in xfs_da_btree.h. xfs_dir2_priv.h had
that dependency, but xfs_dir2.h didn't. Now the conversion functions
have been moved, that dependency moves as well...

> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Did you mean Reviewed-by? :)

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx