| To: | Jan Kara <jack@xxxxxxx> |
|---|---|
| Subject: | Re: [PATCH-v4 1/7] vfs: split update_time() into update_time() and write_time() |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Thu, 27 Nov 2014 07:25:04 -0800 |
| Cc: | Theodore Ts'o <tytso@xxxxxxx>, Linux Filesystem Development List <linux-fsdevel@xxxxxxxxxxxxxxx>, Ext4 Developers List <linux-ext4@xxxxxxxxxxxxxxx>, Linux btrfs Developers List <linux-btrfs@xxxxxxxxxxxxxxx>, XFS Developers <xfs@xxxxxxxxxxx> |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20141127123429.GD30152@xxxxxxxxxxxxx> |
| References: | <1416997437-26092-1-git-send-email-tytso@xxxxxxx> <1416997437-26092-2-git-send-email-tytso@xxxxxxx> <20141126192328.GA20436@xxxxxxxxxxxxx> <20141127123429.GD30152@xxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.23 (2014-03-12) |
On Thu, Nov 27, 2014 at 01:34:29PM +0100, Jan Kara wrote: > But Ted changed XFS to copy timestamps to on-disk structure from the > in-memory inode fields after VFS updated the timestamps. So the stamps > should be coherent AFAICT, shouldn't they? Not coherent enough. We need the XFS ilock to synchronize reading from and writing to the time stamps. update_time() only has i_mutex, which we can't take for the transaction commit path. |
| Previous by Date: | Re: [PATCH-v4 1/7] vfs: split update_time() into update_time() and write_time(), Theodore Ts'o |
|---|---|
| Next by Date: | Re: [PATCH-v4 6/7] ext4: add support for a lazytime mount option, Theodore Ts'o |
| Previous by Thread: | Re: [PATCH-v4 1/7] vfs: split update_time() into update_time() and write_time(), Jan Kara |
| Next by Thread: | Re: [PATCH-v4 1/7] vfs: split update_time() into update_time() and write_time(), Theodore Ts'o |
| Indexes: | [Date] [Thread] [Top] [All Lists] |