Re: [PATCH 04/11] quota: Split ->set_xstate callback into two

To:	Jan Kara <jack@xxxxxxx>
Subject:	Re: [PATCH 04/11] quota: Split ->set_xstate callback into two
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Thu, 13 Nov 2014 09:34:16 -0800
Cc:	linux-fsdevel@xxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx
Delivered-to:	xfs@xxxxxxxxxxx
In-reply-to:	<1415739865-2438-5-git-send-email-jack@xxxxxxx>
References:	<1415739865-2438-1-git-send-email-jack@xxxxxxx> <1415739865-2438-5-git-send-email-jack@xxxxxxx>
User-agent:	Mutt/1.5.23 (2014-03-12)

On Tue, Nov 11, 2014 at 10:04:18PM +0100, Jan Kara wrote:
> Split ->set_xstate callback into two callbacks - one for turning quotas
> on (->sysquota_on) and one for turning quotas off (->sysquota_off). That
> way we don't have to pass quotactl command into the callback which seems
> cleaner.

Yes, I much prefer these to be split.  But the names seem a little odd,
why not enable_quota/disable_quota?

> +static unsigned int generic_to_xfs_flags(unsigned int uflags)

xfs_quota_flags() ?

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 0/11 RFC] quota: Unify VFS and XFS quota interfaces, Jan Kara [PATCH 03/11] xfs: Remove some useless flags tests, Jan Kara Re: [PATCH 03/11] xfs: Remove some useless flags tests, Dave Chinner [PATCH 08/11] ocfs2: Use generic helpers for quotaon and quotaoff, Jan Kara [PATCH 06/11] quota: Add ->sysquota_{on,off} callbacks for VFS quotas, Jan Kara [PATCH 07/11] ext4: Use generic helpers for quotaon and quotaoff, Jan Kara Re: [PATCH 07/11] ext4: Use generic helpers for quotaon and quotaoff, Christoph Hellwig Re: [PATCH 07/11] ext4: Use generic helpers for quotaon and quotaoff, Jan Kara [PATCH 11/11] quota: Store maximum space limit in bytes, Jan Kara [PATCH 04/11] quota: Split ->set_xstate callback into two, Jan Kara Re: [PATCH 04/11] quota: Split ->set_xstate callback into two, Christoph Hellwig <= Re: [PATCH 04/11] quota: Split ->set_xstate callback into two, Jan Kara [PATCH 09/11] quota: Remove quota_on_meta callback, Jan Kara [PATCH 02/11] xfs: Remove unused variable in xfs_qm_scall_quotaon(), Jan Kara Re: [PATCH 02/11] xfs: Remove unused variable in xfs_qm_scall_quotaon(), Dave Chinner [PATCH 01/11] xfs: Remove useless test, Jan Kara Re: [PATCH 01/11] xfs: Remove useless test, Dave Chinner [PATCH 05/11] quota: Wire up ->sysquota_{on,off} callbacks into Q_QUOTA{ON,OFF}, Jan Kara [PATCH 10/11] quota: Switch ->get_dqblk() and ->set_dqblk() to use bytes as space units, Jan Kara Re: [PATCH 10/11] quota: Switch ->get_dqblk() and ->set_dqblk() to use bytes as space units, Dave Chinner

Previous by Date:	[PATCH 2/2] Add support to RENAME_EXCHANGE flag V5, Carlos Maiolino
Next by Date:	Re: [PATCH 4/9] xfsdump: remove pointless if (dirty);, Mark Tinguely
Previous by Thread:	[PATCH 04/11] quota: Split ->set_xstate callback into two, Jan Kara
Next by Thread:	Re: [PATCH 04/11] quota: Split ->set_xstate callback into two, Jan Kara
Indexes:	[Date] [Thread] [Top] [All Lists]