| To: | Dave Kleikamp <dave.kleikamp@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 01/12] quota: Allow each filesystem to specify which quota types it supports |
| From: | Jan Kara <jack@xxxxxxx> |
| Date: | Fri, 10 Oct 2014 17:37:27 +0200 |
| Cc: | Jan Kara <jack@xxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, Dave Chinner <david@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx, cluster-devel@xxxxxxxxxx, Steven Whitehouse <swhiteho@xxxxxxxxxx>, Mark Fasheh <mfasheh@xxxxxxxx>, Joel Becker <jlbec@xxxxxxxxxxxx>, ocfs2-devel@xxxxxxxxxxxxxx, reiserfs-devel@xxxxxxxxxxxxxxx, Jeff Mahoney <jeffm@xxxxxxx>, Dave Kleikamp <shaggy@xxxxxxxxxx>, jfs-discussion@xxxxxxxxxxxxxxxxxxxxx, tytso@xxxxxxx, viro@xxxxxxxxxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <5437FAB1.1010005@xxxxxxxxxx> |
| References: | <1412952910-7142-1-git-send-email-jack@xxxxxxx> <1412952910-7142-2-git-send-email-jack@xxxxxxx> <5437FAB1.1010005@xxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Fri 10-10-14 10:26:41, Dave Kleikamp wrote:
> On 10/10/2014 09:54 AM, Jan Kara wrote:
> > diff --git a/include/linux/quota.h b/include/linux/quota.h
> > index 80d345a3524c..b52539f42e19 100644
> > --- a/include/linux/quota.h
> > +++ b/include/linux/quota.h
> > @@ -56,6 +56,11 @@ enum quota_type {
> > PRJQUOTA = 2, /* element used for project quotas */
> > };
> >
> > +/* Masks for quota types when used as a bitmask */
> > +#define QTYPE_MASK_USER (1 << USRQUOTA)
> > +#define QTYPE_MASK_GROUP (1 << GRPQUOTA)
> > +#define QTYPE_MASK_PROJECT (1 << PRJQUOTA)
>
> The uses of these masks use the names QTYPE_MASK_USR, QTYPE_MASK_GRP,
> and QTYPE_MASK_PRJ
Sigh. Friday afternoon isn't a good time for sending out patch sets :(
Thanks for catching this. I'll wait if someone has other feedback before
resending the patches...
Honza
--
Jan Kara <jack@xxxxxxx>
SUSE Labs, CR
|
| Previous by Date: | Re: [PATCH 11/12] jfs: Convert to private i_dquot field, Dave Kleikamp |
|---|---|
| Next by Date: | Re: [PATCH 11/12] jfs: Convert to private i_dquot field, Jan Kara |
| Previous by Thread: | Re: [PATCH 01/12] quota: Allow each filesystem to specify which quota types it supports, Dave Kleikamp |
| Next by Thread: | [PATCH 03/12] xfs: Set allowed quota types, Jan Kara |
| Indexes: | [Date] [Thread] [Top] [All Lists] |