Re: [PATCH 14/16] xfs: rename XFS_IOC_FSGEOM to XFS_IOC_FSGEOM

To:	Ben Myers <bpm@xxxxxxx>
Subject:	Re: [PATCH 14/16] xfs: rename XFS_IOC_FSGEOM to XFS_IOC_FSGEOM_V2
From:	Dave Chinner <david@xxxxxxxxxxxxx>
Date:	Tue, 7 Oct 2014 07:33:00 +1100
Cc:	linux-fsdevel@xxxxxxxxxxxxxxx, olaf@xxxxxxx, xfs@xxxxxxxxxxx
Delivered-to:	xfs@xxxxxxxxxxx
In-reply-to:	<20141003220435.GN1865@xxxxxxx>
References:	<20141003214758.GY1865@xxxxxxx> <20141003220435.GN1865@xxxxxxx>
User-agent:	Mutt/1.5.21 (2010-09-15)

On Fri, Oct 03, 2014 at 05:04:35PM -0500, Ben Myers wrote:
> From: Ben Myers <bpm@xxxxxxx>
> 
> We'll be creating a new versioned XFS_IOC_FSGEOMETRY ioctl and structure
> so rename the current revision to _V2.

Urk, no.

This will result in older applications picking up the new ioctl when
they are rebuilt without having explicit support for the new ioctl.

Just create a new ioctl with a new name and modify applications to
use it. If the kernel does not support the new ioctl, then fall back
to the old one in userspace.

-Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread]	Current Thread	[Next in Thread>
Re: [PATCH 09/16] xfs: add a superblock feature bit to indicate UTF-8 support., (continued) Re: [PATCH 09/16] xfs: add a superblock feature bit to indicate UTF-8 support., Ben Myers [PATCH 10/16] xfs: store utf8version in the superblock, Ben Myers Re: [PATCH 10/16] xfs: store utf8version in the superblock, Dave Chinner [PATCH 11/16] xfs: add xfs_nameops for utf8 and utf8+casefold., Ben Myers Re: [PATCH 11/16] xfs: add xfs_nameops for utf8 and utf8+casefold., Dave Chinner [PATCH 12/16] xfs: apply utf-8 normalization rules to user extended attribute names, Ben Myers [PATCH 13/16] xfs: implement demand load of utf8norm.ko, Ben Myers Re: [PATCH 13/16] xfs: implement demand load of utf8norm.ko, Christoph Hellwig Re: [PATCH 13/16] xfs: implement demand load of utf8norm.ko, Ben Myers [PATCH 14/16] xfs: rename XFS_IOC_FSGEOM to XFS_IOC_FSGEOM_V2, Ben Myers Re: [PATCH 14/16] xfs: rename XFS_IOC_FSGEOM to XFS_IOC_FSGEOM_V2, Dave Chinner <= Re: [PATCH 14/16] xfs: rename XFS_IOC_FSGEOM to XFS_IOC_FSGEOM_V2, Ben Myers [PATCH 15/16] xfs: xfs_fs_geometry returns a number of bytes to copy, Ben Myers Re: [PATCH 15/16] xfs: xfs_fs_geometry returns a number of bytes to copy, Dave Chinner [PATCH 16/16] xfs: add versioned fsgeom ioctl with utf8version field, Ben Myers Re: [PATCH 16/16] xfs: add versioned fsgeom ioctl with utf8version field, Dave Chinner [PATCH 17/35] xfsprogs: add unicode character database files, Ben Myers [PATCH 18/35] xfsprogs: add trie generator for UTF-8., Ben Myers [PATCH 19/35] xfsprogs: add supporting code for UTF-8., Ben Myers [PATCH 20/35] xfsprogs: reduce the size of utf8data[], Ben Myers [PATCH 21/35] libxfs: return the first match during case-insensitive lookup, Ben Myers

Previous by Date:	Re: [PATCH 03/12] xfs: Set allowed quota types, Dave Chinner
Next by Date:	Re: [PATCH 14/16] xfs: rename XFS_IOC_FSGEOM to XFS_IOC_FSGEOM_V2, Ben Myers
Previous by Thread:	[PATCH 14/16] xfs: rename XFS_IOC_FSGEOM to XFS_IOC_FSGEOM_V2, Ben Myers
Next by Thread:	Re: [PATCH 14/16] xfs: rename XFS_IOC_FSGEOM to XFS_IOC_FSGEOM_V2, Ben Myers
Indexes:	[Date] [Thread] [Top] [All Lists]

Re: [PATCH 14/16] xfs: rename XFS_IOC_FSGEOM to XFS_IOC_FSGEOM_V2