Re: [PATCH 1/2] xfs: don't send null bp to xfs_trans

xfs

Re: [PATCH 1/2] xfs: don't send null bp to xfs_trans_brelse()

To:	Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject:	Re: [PATCH 1/2] xfs: don't send null bp to xfs_trans_brelse()
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Wed, 1 Oct 2014 08:55:29 -0700
Cc:	xfs-oss <xfs@xxxxxxxxxxx>
Delivered-to:	xfs@xxxxxxxxxxx
In-reply-to:	<542C1C2B.5020803@xxxxxxxxxxx>
References:	<542C1B36.5080804@xxxxxxxxxx> <542C1C2B.5020803@xxxxxxxxxxx>
User-agent:	Mutt/1.5.23 (2014-03-12)

On Wed, Oct 01, 2014 at 10:22:19AM -0500, Eric Sandeen wrote:
> In this case, if bp is NULL, error is set, and we send a
> NULL bp to xfs_trans_brelse, which will try to dereference it.
> 
> Test whether we actually have a buffer before we try to
> free it.
> 
> Coverity spotted this.
> 
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 0/2 RESEND] xfs: small bugfixes, Eric Sandeen [PATCH 1/2] xfs: don't send null bp to xfs_trans_brelse(), Eric Sandeen Re: [PATCH 1/2] xfs: don't send null bp to xfs_trans_brelse(), Christoph Hellwig <= [PATCH 2/2] xfs: fix crc field handling in xfs_sb_to/from_disk, Eric Sandeen Re: [PATCH 2/2] xfs: fix crc field handling in xfs_sb_to/from_disk, Christoph Hellwig Re: [PATCH 2/2] xfs: fix crc field handling in xfs_sb_to/from_disk, Dave Chinner

Previous by Date:	[PATCH 2/2] xfs: fix crc field handling in xfs_sb_to/from_disk, Eric Sandeen
Next by Date:	Re: [PATCH 2/2] xfs: fix crc field handling in xfs_sb_to/from_disk, Christoph Hellwig
Previous by Thread:	[PATCH 1/2] xfs: don't send null bp to xfs_trans_brelse(), Eric Sandeen
Next by Thread:	[PATCH 2/2] xfs: fix crc field handling in xfs_sb_to/from_disk, Eric Sandeen
Indexes:	[Date] [Thread] [Top] [All Lists]