Re: [PATCH 1/3] xfs: consider freeze levels in xfs_fs_writable()

[Brian Foster <bfoster@xxxxxxxxxx>]

On Fri, Sep 26, 2014 at 02:44:36AM -0700, Christoph Hellwig wrote:
> On Fri, Sep 26, 2014 at 07:03:30AM +1000, Dave Chinner wrote:
> > I can mention it, but it's so trivial I didn't think it was worth
> > it.
> 
> It does change behavior, so it should document why that was changed.
> 
> > The changelog says "Hence allow the caller to pass in the freeze
> > level it is allowed to write" which is exactly what this code is
> > doing.
> 
> The changelog says the you can pass the argument now.  It doesn't
> say that it did change a caller to pass a different argument, and more
> importanly why.
> 

Note that iirc the patch I posted had a bug so this one is preferred,
but feel free to steal the commit log/problem description from the old
one:

http://oss.sgi.com/archives/xfs/2014-08/msg00073.html

Brian

> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs