Re: [PATCH 2/5] xfs_repair: preserve error state in process_shortform

xfs

Re: [PATCH 2/5] xfs_repair: preserve error state in process_shortform_at

To:	Eric Sandeen <sandeen@xxxxxxxxxx>
Subject:	Re: [PATCH 2/5] xfs_repair: preserve error state in process_shortform_attr
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Tue, 9 Sep 2014 15:29:53 -0700
Cc:	xfs@xxxxxxxxxxx
Delivered-to:	xfs@xxxxxxxxxxx
In-reply-to:	<1410108065-18156-3-git-send-email-sandeen@xxxxxxxxxx>
References:	<1410108065-18156-1-git-send-email-sandeen@xxxxxxxxxx> <1410108065-18156-3-git-send-email-sandeen@xxxxxxxxxx>
User-agent:	Mutt/1.5.23 (2014-03-12)

On Sun, Sep 07, 2014 at 11:41:02AM -0500, Eric Sandeen wrote:
> process_shortform_attr uses the "junkit" error to
> track whether an error was found, but by assigning
> it directly to the result of valuecheck, previous
> errors are ignored, leading to unrepairable errors
> of the form i.e.
> 
> "entry has INCOMPLETE flag on in shortform attribute"
> or
> "entry contains illegal character in shortform attribute name"
> 
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 0/5] xfs_repair fixes, part 1, Eric Sandeen [PATCH 2/5] xfs_repair: preserve error state in process_shortform_attr, Eric Sandeen Re: [PATCH 2/5] xfs_repair: preserve error state in process_shortform_attr, Brian Foster Re: [PATCH 2/5] xfs_repair: preserve error state in process_shortform_attr, Christoph Hellwig <= [PATCH 4/5] xfs_repair: don't ASSERT on corrupt ftype, Eric Sandeen Re: [PATCH 4/5] xfs_repair: don't ASSERT on corrupt ftype, Dave Chinner Re: [PATCH 4/5] xfs_repair: don't ASSERT on corrupt ftype, Eric Sandeen Re: [PATCH 4/5] xfs_repair: don't ASSERT on corrupt ftype, Dave Chinner Re: [PATCH 4/5] xfs_repair: don't ASSERT on corrupt ftype, Eric Sandeen Re: [PATCH 4/5] xfs_repair: don't ASSERT on corrupt ftype, Dave Chinner [PATCH 5/5] xfs_repair: set proper ftype when moving to lost+found, Eric Sandeen Re: [PATCH 5/5] xfs_repair: set proper ftype when moving to lost+found, Eric Sandeen [PATCH 3/5] xfs_repair: fix dir refcount when '.' missing and dir is rebuilt, Eric Sandeen Re: [PATCH 3/5] xfs_repair: fix dir refcount when '.' missing and dir is rebuilt, Brian Foster

Previous by Date:	Re: [PATCH 1/5] xfs_repair: clear bad flgs in process_dinode_int, Christoph Hellwig
Next by Date:	Re: [PATCH 1/5] xfs_repair: clear bad flgs in process_dinode_int, Eric Sandeen
Previous by Thread:	Re: [PATCH 2/5] xfs_repair: preserve error state in process_shortform_attr, Brian Foster
Next by Thread:	[PATCH 4/5] xfs_repair: don't ASSERT on corrupt ftype, Eric Sandeen
Indexes:	[Date] [Thread] [Top] [All Lists]