| To: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 2/9] xfs: xfs_buf_ioend and xfs_buf_iodone_work duplicate functionality |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Fri, 29 Aug 2014 10:55:43 +1000 |
| Cc: | xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20140829002209.GB17502@xxxxxxxxxxxxx> |
| References: | <1408084747-4540-1-git-send-email-david@xxxxxxxxxxxxx> <1408084747-4540-3-git-send-email-david@xxxxxxxxxxxxx> <20140829002209.GB17502@xxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Thu, Aug 28, 2014 at 05:22:09PM -0700, Christoph Hellwig wrote: > > STATIC void > > needs the static removed as pointed out by Brian. > > - bool read = !!(bp->b_flags & XBF_READ); > > + bool read = !!(bp->b_flags & XBF_READ); > > We don't really need the double negation here. Good point. I'll fix it. -- Dave Chinner david@xxxxxxxxxxxxx |
| Previous by Date: | Re: [PATCH 1/7] xfs: don't dirty buffers beyond EOF, Dave Chinner |
|---|---|
| Next by Date: | Re: [PATCH 1/4] xfs: check resblks before calling xfs_dir_canenter, Christoph Hellwig |
| Previous by Thread: | Re: [PATCH 2/9] xfs: xfs_buf_ioend and xfs_buf_iodone_work duplicate functionality, Christoph Hellwig |
| Next by Thread: | [PATCH 9/9] xfs: check xfs_buf_read_uncached returns correctly, Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |