| To: | Dave Chinner <david@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 9/9] xfs: check xfs_buf_read_uncached returns correctly |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Thu, 28 Aug 2014 17:37:56 -0700 |
| Cc: | Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20140815235843.GA26465@dastard> |
| References: | <1408084747-4540-1-git-send-email-david@xxxxxxxxxxxxx> <1408084747-4540-10-git-send-email-david@xxxxxxxxxxxxx> <20140815125608.GA27856@xxxxxxxxxxxxx> <20140815235843.GA26465@dastard> |
| User-agent: | Mutt/1.5.23 (2014-03-12) |
On Sat, Aug 16, 2014 at 09:58:43AM +1000, Dave Chinner wrote: > > I'd rather get rid of these annoying calling conventions. Make it > > return and errno, and the bp in a pointer argument, with the bp > > never non-NULL in case of error. > > Ok. I considered that, then just did the simple thing. There's only about a dozen callers of all xfs_buf_read* variants, so I think switching them over to return an errno shouldn't be much of a problem. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 6/9] xfs: kill xfs_bioerror_relse, Christoph Hellwig |
|---|---|
| Next by Date: | Re: [PATCH 1/7] xfs: don't dirty buffers beyond EOF, Christoph Hellwig |
| Previous by Thread: | Re: [PATCH 9/9] xfs: check xfs_buf_read_uncached returns correctly, Dave Chinner |
| Next by Thread: | [PATCH 1/9] xfs: synchronous buffer IO needs a reference, Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |