| To: | Dave Chinner <david@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 2/9] xfs: xfs_buf_ioend and xfs_buf_iodone_work duplicate functionality |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Thu, 28 Aug 2014 17:22:09 -0700 |
| Cc: | xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1408084747-4540-3-git-send-email-david@xxxxxxxxxxxxx> |
| References: | <1408084747-4540-1-git-send-email-david@xxxxxxxxxxxxx> <1408084747-4540-3-git-send-email-david@xxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.23 (2014-03-12) |
> STATIC void needs the static removed as pointed out by Brian. > - bool read = !!(bp->b_flags & XBF_READ); > + bool read = !!(bp->b_flags & XBF_READ); We don't really need the double negation here. Otherwise this looks reasonable to me. |
| Previous by Date: | Re: [PATCH 1/9] xfs: synchronous buffer IO needs a reference, Christoph Hellwig |
|---|---|
| Next by Date: | Re: [PATCH 3/9] xfs: rework xfs_buf_bio_endio error handling, Christoph Hellwig |
| Previous by Thread: | Re: [PATCH 2/9] xfs: xfs_buf_ioend and xfs_buf_iodone_work duplicate functionality, Brian Foster |
| Next by Thread: | Re: [PATCH 2/9] xfs: xfs_buf_ioend and xfs_buf_iodone_work duplicate functionality, Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |