Re: [PATCH] xfs: Remove typedef xfs_uu

xfs

Re: [PATCH] xfs: Remove typedef xfs_uu_t

To:	Himangi Saraogi <himangi774@xxxxxxxxx>
Subject:	Re: [PATCH] xfs: Remove typedef xfs_uu_t
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Wed, 6 Aug 2014 07:28:47 -0700
Cc:	Dave Chinner <david@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Julia Lawall <julia.lawall@xxxxxxx>
Delivered-to:	xfs@xxxxxxxxxxx
In-reply-to:	<20140806141343.GA15659@himangi-Dell>
References:	<20140806141343.GA15659@himangi-Dell>
User-agent:	Mutt/1.5.23 (2014-03-12)

On Wed, Aug 06, 2014 at 07:43:43PM +0530, Himangi Saraogi wrote:
> The Linux kernel coding style guidelines suggest not using typedefs
> for structure types. This patch gets rid of the typedef for xfs_uu_t.
> Also the names of the struct is changed to drop the _t, to make the
> name look less typedef-like.

The right fix is to just kill the type, and read the values directly
from the uuid_t type using get_unaligned_be16.

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH] xfs: Remove typedef xfs_uu_t, Himangi Saraogi Re: [PATCH] xfs: Remove typedef xfs_uu_t, Christoph Hellwig <=

Previous by Date:	Re: xfs_bmbt_rec_64 leading to wrong blocks, Brian Foster
Next by Date:	Re: use-after-free on log replay failure, Alex Lyakas
Previous by Thread:	[PATCH] xfs: Remove typedef xfs_uu_t, Himangi Saraogi
Next by Thread:	[DISCUSS] Moving from oss.sgi.com to kernel.org, Dave Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]