Re: [PATCH 6/6] xfs: kill xfs

xfs

Re: [PATCH 6/6] xfs: kill xfs_vnode.h

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 6/6] xfs: kill xfs_vnode.h
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Thu, 31 Jul 2014 10:14:25 -0700
Cc:	xfs@xxxxxxxxxxx
Delivered-to:	xfs@xxxxxxxxxxx
In-reply-to:	<1406791995-14723-7-git-send-email-david@xxxxxxxxxxxxx>
References:	<1406791995-14723-1-git-send-email-david@xxxxxxxxxxxxx> <1406791995-14723-7-git-send-email-david@xxxxxxxxxxxxx>
User-agent:	Mutt/1.5.23 (2014-03-12)

On Thu, Jul 31, 2014 at 05:33:15PM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> Move the IO flag definitions to xfs_inode.h and kill the header file
> as it is now empty.
> 
> Removing the xfs_vnode.h file showed up an implicit header include
> path:
>       xfs_linux.h -> xfs_vnode.h -> xfs_fs.h
> 
> And so every xfs header file has been inplicitly been including
> xfs_fs.h where it is needed or not. Hence the removal of xfs_vnode.h
> causes all sorts of build issues because BBTOB() and friends are no
> longer automatically included in the build. This also gets fixed.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
> Signed-off-by: Dave Chinner <david@xxxxxxxxxxxxx>

Looks fine,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 0/6] xfs: discombobulate sb updates and kill xfs_vnode.h, Dave Chinner [PATCH 3/6] xfs: kill VN_DIRTY(), Dave Chinner Re: [PATCH 3/6] xfs: kill VN_DIRTY(), Christoph Hellwig [PATCH 5/6] xfs: kill VN_MAPPED, Dave Chinner Re: [PATCH 5/6] xfs: kill VN_MAPPED, Christoph Hellwig [PATCH 4/6] xfs: kill VN_CACHED, Dave Chinner Re: [PATCH 4/6] xfs: kill VN_CACHED, Christoph Hellwig [PATCH 6/6] xfs: kill xfs_vnode.h, Dave Chinner Re: [PATCH 6/6] xfs: kill xfs_vnode.h, Christoph Hellwig <= [PATCH 1/6] xfs: remove bitfield based superblock updates, Dave Chinner [PATCH 2/6] xfs: consolidate superblock logging functions, Dave Chinner Re: [PATCH 0/6] xfs: discombobulate sb updates and kill xfs_vnode.h, Christoph Hellwig Re: [PATCH 0/6] xfs: discombobulate sb updates and kill xfs_vnode.h, Dave Chinner

Previous by Date:	Re: [PATCH 5/6] xfs: kill VN_MAPPED, Christoph Hellwig
Next by Date:	Re: [PATCH 1/2] xfs: fix swapext ilock deadlock, Christoph Hellwig
Previous by Thread:	[PATCH 6/6] xfs: kill xfs_vnode.h, Dave Chinner
Next by Thread:	[PATCH 1/6] xfs: remove bitfield based superblock updates, Dave Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]