Re: [PATCH] logprint: Fix printing of AGF buffers

[Jan Kara <jack@xxxxxxx>]

On Wed 16-07-14 01:11:05, Christoph Hellwig wrote:
> On Wed, Jul 16, 2014 at 10:38:51AM +1000, Dave Chinner wrote:
> > I added this:
> > 
> >     /*
> >      * The addition of spare space and the non-logged CRC format
> >      * fields to the AGF mean that the size that is logged is almost
> >      * always going to be smaller than the structure itself. Hence
> >      * we need to make sure that the buffer contains all the data we
> >      * want to print rather than just check against the structure
> >      * size.
> >      */
> > 
> > Cheers,
> 
> I'd prefer to mention v4 filesystems as well:
> 
>       /*
>        * v4 filesystems only contain the fields before the uuid, and
>        * even v5 filesystems don't usually log any field beneath it.
>        */
> 
> note that the AGI case also needs the same treatment.
  Yep, I'll send an updated patch in a moment.

                                                                Honza
-- 
Jan Kara <jack@xxxxxxx>
SUSE Labs, CR