| To: | Mark Tinguely <tinguely@xxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 4/5] xfs: free inodes on log recovery error |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Wed, 9 Jul 2014 02:02:24 -0700 |
| Cc: | xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20140702144139.894251516@xxxxxxx> |
| References: | <20140702143206.438456679@xxxxxxx> <20140702144139.894251516@xxxxxxx> |
| User-agent: | Mutt/1.5.23 (2014-03-12) |
On Wed, Jul 02, 2014 at 09:32:10AM -0500, Mark Tinguely wrote: > Recovery may free inodes that end up on the inode > reclaim RCU. If recovery fails, we leak these inodes. > The filesystem should be in forced shutdown at this > point, so a call to xfs_reclaim_inode is a fast path > to freeing the inodes and RCU entries. I haven't really started reviewing the series, but your terminology here seems wrong. RCU is just a way to synchronize updates - do you mean inodes are marked as reclaimable in the radix tree? |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 2/2] repair: handle uncorrected corruptions in phase 2, Christoph Hellwig |
|---|---|
| Next by Date: | symlink loop for /lib64/libhandle.so, Jan ÅulÃk |
| Previous by Thread: | Re: [PATCH 4/5] xfs: free inodes on log recovery error, Mark Tinguely |
| Next by Thread: | [PATCH 5/5] xfs: fix cil push sequence after log recovery, Mark Tinguely |
| Indexes: | [Date] [Thread] [Top] [All Lists] |