| To: | Dave Chinner <david@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 3/6] repair: handle directory block corruption in phase 6 |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Fri, 4 Jul 2014 07:24:22 -0700 |
| Cc: | xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1404453435-1915-4-git-send-email-david@xxxxxxxxxxxxx> |
| References: | <1404453435-1915-1-git-send-email-david@xxxxxxxxxxxxx> <1404453435-1915-4-git-send-email-david@xxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.23 (2014-03-12) |
> @@ -2179,7 +2179,7 @@ longform_dir2_entry_check(xfs_mount_t *mp,
> freetab = malloc(FREETAB_SIZE(ip->i_d.di_size / mp->m_dirblksize));
> if (!freetab) {
> do_error(
> - _("malloc failed in longform_dir2_entry_check (%" PRId64 "
> bytes)\n"),
> +_("malloc failed in longform_dir2_entry_check (%" PRId64 " bytes)\n"),
Use __func__ to make this both more readable and future proof (same for
the other error message).
Otherwise looks good,
Reviewed-by: Christoph Hellwig <hch@xxxxxx>
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 1/6] repair: support more than 25 ACLs, Christoph Hellwig |
|---|---|
| Next by Date: | Re: [PATCH 5/6] repair: fix quota inode handling in secondary superblocks, Christoph Hellwig |
| Previous by Thread: | [PATCH 3/6] repair: handle directory block corruption in phase 6, Dave Chinner |
| Next by Thread: | Oportunidade Ãnica: MedPlex - Complexo MÃdico Cyrela Goldsztein, Carlos Pedrollo Corretor Foxter |
| Indexes: | [Date] [Thread] [Top] [All Lists] |