| To: | Brian Foster <bfoster@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 1/6] xfs: fix a couple error sequence jumps in xfs_mountfs() |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Thu, 26 Jun 2014 14:10:03 +1000 |
| Cc: | xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1402060414-22075-2-git-send-email-bfoster@xxxxxxxxxx> |
| References: | <1402060414-22075-1-git-send-email-bfoster@xxxxxxxxxx> <1402060414-22075-2-git-send-email-bfoster@xxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Fri, Jun 06, 2014 at 09:13:29AM -0400, Brian Foster wrote: > xfs_mountfs() has a couple failure conditions that do not jump to the > correct labels. Specifically: > > - xfs_initialize_perag_data() failure does not deallocate the log even > though it occurs after log initialization > - xfs_mount_reset_sbqflags() failure returns the error directly rather > than jump to the error sequence > > Signed-off-by: Brian Foster <bfoster@xxxxxxxxxx> Looks good. Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx> Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: Metadata CRC error upon unclean unmount, Dave Chinner |
|---|---|
| Next by Date: | Re: [PATCH 2/6] xfs: add a sysfs kset, Dave Chinner |
| Previous by Thread: | [PATCH 1/6] xfs: fix a couple error sequence jumps in xfs_mountfs(), Brian Foster |
| Next by Thread: | [PATCH 2/6] xfs: add a sysfs kset, Brian Foster |
| Indexes: | [Date] [Thread] [Top] [All Lists] |