| To: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 02/16] xfs: move directory block translatiosn to xfs_da_btree.h |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Wed, 28 May 2014 09:06:36 +1000 |
| Cc: | xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20140527104638.GE1440@xxxxxxxxxxxxx> |
| References: | <1400803432-20048-1-git-send-email-david@xxxxxxxxxxxxx> <1400803432-20048-3-git-send-email-david@xxxxxxxxxxxxx> <20140527104638.GE1440@xxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Tue, May 27, 2014 at 03:46:38AM -0700, Christoph Hellwig wrote: > On Fri, May 23, 2014 at 10:03:38AM +1000, Dave Chinner wrote: > > From: Dave Chinner <dchinner@xxxxxxxxxx> > > > > Because they aren't actually part of the on-disk format, and so > > shouldn't be in xfs_da_format.h. > > > > Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx> > > Maybe it's time to rename the functions and types from xfs_dir2_* to > xfs_da_* as we already do for some? If not this should stay in dir2 > headers. Fair call - they really are dir2 specific, so probably should be in xfs_dir2_priv.h, not xfs_da_btree.h. OK, I can update this patch to do that. I'll need to repost the series, because I'll have to rework a significant number of the patches... Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx |
| Previous by Date: | Re: [PATCH v2 2/7] xfs: add support FALLOC_FL_COLLAPSE_RANGE for fallocate, Mark Tinguely |
|---|---|
| Next by Date: | Re: [PATCH 11/16] xfs: move node entry counts to xfs_da_geometry, Dave Chinner |
| Previous by Thread: | Re: [PATCH 02/16] xfs: move directory block translatiosn to xfs_da_btree.h, Christoph Hellwig |
| Next by Thread: | Re: [PATCH 02/16] xfs: move directory block translatiosn to xfs_da_btree.h, Christoph Hellwig |
| Indexes: | [Date] [Thread] [Top] [All Lists] |