Re: [PATCH 3/5] xfs: turn NLINK feature on by default

[Christoph Hellwig <hch@xxxxxxxxxxxxx>]

> diff --git a/fs/xfs/xfs_mount.c b/fs/xfs/xfs_mount.c
> index 944f3d9..3f09782 100644
> --- a/fs/xfs/xfs_mount.c
> +++ b/fs/xfs/xfs_mount.c
> @@ -697,6 +697,12 @@ xfs_mountfs(
>                       mp->m_update_flags |= XFS_SB_VERSIONNUM;
>       }
>  
> +     /* always use v2 inodes by default now */
> +     if (!(mp->m_sb.sb_versionnum & XFS_SB_VERSION_NLINKBIT)) {
> +             mp->m_sb.sb_versionnum |= XFS_SB_VERSION_NLINKBIT;
> +             mp->m_update_flags |= XFS_SB_VERSIONNUM;
> +     }

This probably should print a message for the user.

Otherwise looks fine,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>