| To: | Brian Foster <bfoster@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [RFC] libxfs kernel infrastructure (was [XFS updates] XFS development tree branch, xfs-libxfs-in-kernel-RFC, created. xfs-for-linus-3.15-rc2-52-g6579dd8) |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Fri, 9 May 2014 07:21:20 +1000 |
| Cc: | Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20140508134520.GC47272@xxxxxxxxxxxxxxx> |
| References: | <20140506071855.F152E7FBC@xxxxxxxxxxx> <20140506075905.GA5421@dastard> <20140507144822.GA4061@xxxxxxxxxxxxxxx> <20140507224755.GR5421@dastard> <20140508011256.GS5421@dastard> <20140508120228.GA47272@xxxxxxxxxxxxxxx> <20140508125405.GA8096@xxxxxxxxxxxxx> <20140508134520.GC47272@xxxxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Thu, May 08, 2014 at 09:45:20AM -0400, Brian Foster wrote: > On Thu, May 08, 2014 at 05:54:05AM -0700, Christoph Hellwig wrote: > > On Thu, May 08, 2014 at 08:02:28AM -0400, Brian Foster wrote: > > > Missing a $ here... > > > > > > Adding that, the single threaded build still breaks for me. E.g., > > > > > > - rm -rf fs/xfs > > > - git checkout -- . > > > - make > > > > The kernel build systems doesn't support building a single module from > > multiple makefiles. Take a look how to handle a subdirectory in the > > older XFS versions that still had that linux-2.6 subdirectory, it just > > pulls the files in the subdirectory in from the main makefile, which > > requires some tiny hacks for the include path. > > > > Good point, I was looking around for some example of this and didn't see > anything obvious, but didn't think to look back to that. Indeed it does > just reference the files in the subdirectory... thanks. I haven't looked at that, but I'm assuming that it is just a -include libxfs/Makefile directive rather than using: obj-y += libxfs/ If that's all it takes, then I'll rebase the patch on that.... Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx |
| Previous by Date: | Re: Remove xfs_check for 3.2.0?, Emmanuel Florac |
|---|---|
| Next by Date: | Re: [PATCH] xfs: remove XFS_TRANS_RESERVE in collapse range, Brian Foster |
| Previous by Thread: | Re: [RFC] libxfs kernel infrastructure (was [XFS updates] XFS development tree branch, xfs-libxfs-in-kernel-RFC, created. xfs-for-linus-3.15-rc2-52-g6579dd8), Brian Foster |
| Next by Thread: | Re: [RFC] libxfs kernel infrastructure (was [XFS updates] XFS development tree branch, xfs-libxfs-in-kernel-RFC, created. xfs-for-linus-3.15-rc2-52-g6579dd8), Christoph Hellwig |
| Indexes: | [Date] [Thread] [Top] [All Lists] |