Re: [PATCH v5 03/11] xfs: support the XFS_BTNUM_FINOBT free inode btree type

[Dave Chinner <david@xxxxxxxxxxxxx>]

On Thu, Apr 10, 2014 at 12:08:28PM -0400, Brian Foster wrote:
> Define the AGI fields for the finobt root/level and add magic
> numbers. Update the btree code to add support for the new
> XFS_BTNUM_FINOBT inode btree.
> 
> The finobt root block is reserved immediately following the inobt
> root block in the AG. Update XFS_PREALLOC_BLOCKS() to determine the
> starting AG data block based on whether finobt support is enabled.
> 
> Signed-off-by: Brian Foster <bfoster@xxxxxxxxxx>

Looks good.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

FWIW, xfstests doesn't give us particularly good coverage of all
the finobt operations:

$ $ grep fibt /proc/fs/xfs/stat 
fibt2 43617 50359 338 336 0 0 0 0 0 0 0 0 0 0 136

So perhaps we want to look at improving that over time.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx