Re: [PATCH 09/19] XFS: ensure xfs_file_*_read cannot deadlock in memory

To:	NeilBrown <neilb@xxxxxxx>
Subject:	Re: [PATCH 09/19] XFS: ensure xfs_file_*_read cannot deadlock in memory allocation.
From:	Dave Chinner <david@xxxxxxxxxxxxx>
Date:	Wed, 16 Apr 2014 16:31:29 +1000
Cc:	linux-mm@xxxxxxxxx, linux-nfs@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx
Delivered-to:	xfs@xxxxxxxxxxx
In-reply-to:	<20140416060459.GE15995@dastard>
References:	<20140416033623.10604.69237.stgit@xxxxxxxxxxxxxx> <20140416040336.10604.90380.stgit@xxxxxxxxxxxxxx> <20140416060459.GE15995@dastard>
User-agent:	Mutt/1.5.21 (2010-09-15)

On Wed, Apr 16, 2014 at 04:04:59PM +1000, Dave Chinner wrote:
> On Wed, Apr 16, 2014 at 02:03:36PM +1000, NeilBrown wrote:
> > xfs_file_*_read holds an inode lock while calling a generic 'read'
> > function.  These functions perform read-ahead and are quite likely to
> > allocate memory.
> 
> Yes, that's what reading data from disk requires.
> 
> > So set PF_FSTRANS to ensure they avoid __GFP_FS and so don't recurse
> > into a filesystem to free memory.
> 
> We already have that protection via the

Oops, stray paste. Ignore that comment.

-Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 05/19] SUNRPC: track whether a request is coming from a loop-back interface., (continued) [PATCH 05/19] SUNRPC: track whether a request is coming from a loop-back interface., NeilBrown Re: [PATCH 05/19] SUNRPC: track whether a request is coming from a loop-back interface., Jeff Layton Re: [PATCH 05/19] SUNRPC: track whether a request is coming from a loop-back interface., NeilBrown [PATCH 06/19] nfsd: set PF_FSTRANS for nfsd threads., NeilBrown Re: [PATCH 06/19] nfsd: set PF_FSTRANS for nfsd threads., Peter Zijlstra [PATCH 07/19] nfsd and VM: use PF_LESS_THROTTLE to avoid throttle in shrink_inactive_list., NeilBrown [PATCH 08/19] Set PF_FSTRANS while write_cache_pages calls ->writepage, NeilBrown *[PATCH 09/19] XFS: ensure xfs_file__read cannot deadlock in memory allocation.*, NeilBrown* *Re: [PATCH 09/19] XFS: ensure xfs_file__read cannot deadlock in memory allocation.*, Dave Chinner* *Re: [PATCH 09/19] XFS: ensure xfs_file__read cannot deadlock in memory allocation.*, NeilBrown* *Re: [PATCH 09/19] XFS: ensure xfs_file__read cannot deadlock in memory allocation.*, Dave Chinner* <= [PATCH 10/19] NET: set PF_FSTRANS while holding sk_lock, NeilBrown Re: [PATCH 10/19] NET: set PF_FSTRANS while holding sk_lock, Eric Dumazet Re: [PATCH 10/19] NET: set PF_FSTRANS while holding sk_lock, NeilBrown Re: [PATCH 10/19] NET: set PF_FSTRANS while holding sk_lock, David Miller Re: [PATCH 10/19] NET: set PF_FSTRANS while holding sk_lock, NeilBrown [PATCH 11/19] FS: set PF_FSTRANS while holding mmap_sem in exec.c, NeilBrown [PATCH 12/19] NET: set PF_FSTRANS while holding rtnl_lock, NeilBrown [PATCH 13/19] MM: set PF_FSTRANS while allocating per-cpu memory to avoid deadlock., NeilBrown Re: [PATCH 13/19] MM: set PF_FSTRANS while allocating per-cpu memory to avoid deadlock., Dave Chinner Re: [PATCH 13/19] MM: set PF_FSTRANS while allocating per-cpu memory to avoid deadlock., NeilBrown

Previous by Date:	Re: [PATCH 13/19] MM: set PF_FSTRANS while allocating per-cpu memory to avoid deadlock., Dave Chinner
Next by Date:	Re: [PATCH 0/6][RFC] Introduce FALLOC_FL_ZERO_RANGE flag for fallocate, Christoph Hellwig
Previous by Thread:	*Re: [PATCH 09/19] XFS: ensure xfs_file__read cannot deadlock in memory allocation.*, NeilBrown*
Next by Thread:	[PATCH 10/19] NET: set PF_FSTRANS while holding sk_lock, NeilBrown
Indexes:	[Date] [Thread] [Top] [All Lists]