Re: [PATCH 2/3 v2] fs: Prevent doing FALLOC_FL_ZERO

xfs

Re: [PATCH 2/3 v2] fs: Prevent doing FALLOC_FL_ZERO_RANGE on append only

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 2/3 v2] fs: Prevent doing FALLOC_FL_ZERO_RANGE on append only file
From:	Theodore Ts'o <tytso@xxxxxxx>
Date:	Tue, 15 Apr 2014 22:51:34 -0400
Cc:	Lukas Czerner <lczerner@xxxxxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx
Delivered-to:	xfs@xxxxxxxxxxx
Dkim-signature:	v=1; a=rsa-sha256; c=simple/simple; d=thunk.org; s=ef5046eb; t=1397616694; bh=q9mp33YKRnfZ+ad6zQz3n0drM7SDU2qCUWnGnhpOfSE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VdX3r9k5hhAiSGHLk9F4lUn7tHaqQuqaDUL9Z6ni9Qj5X4odYUfe2kpl0kck+3Bb9 GTREg6lLpiIQ/KYqDA8lzUlEmxp9A0WfIXP1Rm0dEqI2wtw4lkpjmp5FwUPxtPE2dR TBxyCUBzlP5hVFPJWc2k17LqkXCK28b6ckbOKCfA=
In-reply-to:	<20140415220220.GR15995@dastard>
References:	<1397580076-19826-1-git-send-email-lczerner@xxxxxxxxxx> <1397580076-19826-2-git-send-email-lczerner@xxxxxxxxxx> <20140415220220.GR15995@dastard>
User-agent:	Mutt/1.5.23 (2014-03-12)

On Wed, Apr 16, 2014 at 08:02:20AM +1000, Dave Chinner wrote:
> On Tue, Apr 15, 2014 at 06:41:15PM +0200, Lukas Czerner wrote:
> > Currently punch hole and collapse range fallocate operation are not
> > allowed on append only file. This should be case for zero range as well.
> > Fix it by allowing only pure fallocate (possibly with keep size set).
> > 
> > Signed-off-by: Lukas Czerner <lczerner@xxxxxxxxxx>

Thanks, updated with Dave's suggested added parenthesis.

                                                - Ted

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 1/3 v2] ext4: Remove unnecessary check for APPEND and IMMUTABLE, Lukas Czerner [PATCH 2/3 v2] fs: Prevent doing FALLOC_FL_ZERO_RANGE on append only file, Lukas Czerner Re: [PATCH 2/3 v2] fs: Prevent doing FALLOC_FL_ZERO_RANGE on append only file, Dave Chinner Re: [PATCH 2/3 v2] fs: Prevent doing FALLOC_FL_ZERO_RANGE on append only file, Theodore Ts'o <= Re: [PATCH 2/3 v2] fs: Prevent doing FALLOC_FL_ZERO_RANGE on append only file, Lukáš Czerner [PATCH 3/3 v2] fs: move falloc collapse range check into the filesystem methods, Lukas Czerner Re: [PATCH 3/3 v2] fs: move falloc collapse range check into the filesystem methods, Theodore Ts'o

Previous by Date:	Re: [PATCH 3/9] repair: ensure prefetched buffers have CRCs validated, Dave Chinner
Next by Date:	Re: [PATCH 3/3 v2] fs: move falloc collapse range check into the filesystem methods, Theodore Ts'o
Previous by Thread:	Re: [PATCH 2/3 v2] fs: Prevent doing FALLOC_FL_ZERO_RANGE on append only file, Dave Chinner
Next by Thread:	Re: [PATCH 2/3 v2] fs: Prevent doing FALLOC_FL_ZERO_RANGE on append only file, Lukáš Czerner
Indexes:	[Date] [Thread] [Top] [All Lists]