Re: [xfstests PATCH] renameat2 syscall: turn EEXIST into ENOTEMPTY

xfs

Re: [xfstests PATCH] renameat2 syscall: turn EEXIST into ENOTEMPTY

To:	Miklos Szeredi <miklos@xxxxxxxxxx>
Subject:	Re: [xfstests PATCH] renameat2 syscall: turn EEXIST into ENOTEMPTY
From:	Dave Chinner <david@xxxxxxxxxxxxx>
Date:	Wed, 16 Apr 2014 10:31:05 +1000
Cc:	xfs@xxxxxxxxxxx
Delivered-to:	xfs@xxxxxxxxxxx
In-reply-to:	<20140414104953.GE10187@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
References:	<20140414104953.GE10187@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
User-agent:	Mutt/1.5.21 (2010-09-15)

On Mon, Apr 14, 2014 at 12:49:53PM +0200, Miklos Szeredi wrote:
> From: Miklos Szeredi <mszeredi@xxxxxxx>
> 
> XFS is returning EEXIST rather than ENOTEMPTY for several of
> these rename tests. The rename man page says this about the errors:
> 
>        ENOTEMPTY or EEXIST
>               newpath is a nonempty directory, that is, contains
>               entries other than "." and "..".
> 
> Which implies that both errors are valid and so the test should pass
> in either case.
> 
> Signed-off-by: Miklos Szeredi <mszeredi@xxxxxxx>

looks good.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>
-- 
Dave Chinner
david@xxxxxxxxxxxxx

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[xfstests PATCH] renameat2 syscall: turn EEXIST into ENOTEMPTY, Miklos Szeredi Re: [xfstests PATCH] renameat2 syscall: turn EEXIST into ENOTEMPTY, Dave Chinner <=

Previous by Date:	Re: [PATCH] xfstests: btrfs, add test for btrfs properties, Dave Chinner
Next by Date:	Re: [PATCH] renameat2: add system call number for i386, Dave Chinner
Previous by Thread:	[xfstests PATCH] renameat2 syscall: turn EEXIST into ENOTEMPTY, Miklos Szeredi
Next by Thread:	[PATCH 0/2] xfsprogs: 2 quick coverity fixes, Eric Sandeen
Indexes:	[Date] [Thread] [Top] [All Lists]