| To: | Brian Foster <bfoster@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH v3 3/4] xfs: replace on-stack xfs_trans_res with pointer in xfs_create() |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Tue, 15 Apr 2014 10:50:51 -0700 |
| Cc: | xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1397578706-5385-4-git-send-email-bfoster@xxxxxxxxxx> |
| References: | <1397578706-5385-1-git-send-email-bfoster@xxxxxxxxxx> <1397578706-5385-4-git-send-email-bfoster@xxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Tue, Apr 15, 2014 at 12:18:25PM -0400, Brian Foster wrote: > There's no need to store a full struct xfs_trans_res on the stack in > xfs_create() and copy the fields. Use a pointer to the appropriate > structures embedded in the xfs_mount. > > Signed-off-by: Brian Foster <bfoster@xxxxxxxxxx> Looks good, Reviewed-by: Christoph Hellwig <hch@xxxxxx> |
| Previous by Date: | Re: [PATCH v3 2/4] xfs: initialize inode security on tmpfile creation, Christoph Hellwig |
|---|---|
| Next by Date: | Re: [PATCH v3 4/4] xfs: fold xfs_create_tmpfile() into xfs_create(), Christoph Hellwig |
| Previous by Thread: | [PATCH v3 3/4] xfs: replace on-stack xfs_trans_res with pointer in xfs_create(), Brian Foster |
| Next by Thread: | [PATCH v3 1/4] xfs: fix tmpfile/selinux ilock deadlock, Brian Foster |
| Indexes: | [Date] [Thread] [Top] [All Lists] |