| To: | Brian Foster <bfoster@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH v3 2/4] xfs: initialize inode security on tmpfile creation |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Tue, 15 Apr 2014 10:50:33 -0700 |
| Cc: | xfs@xxxxxxxxxxx, linux-security-module@xxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1397578706-5385-3-git-send-email-bfoster@xxxxxxxxxx> |
| References: | <1397578706-5385-1-git-send-email-bfoster@xxxxxxxxxx> <1397578706-5385-3-git-send-email-bfoster@xxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Tue, Apr 15, 2014 at 12:18:24PM -0400, Brian Foster wrote:
> + error = xfs_init_security(inode, dir, &dentry->d_name);
> + if (unlikely(error)) {
> + iput(inode);
> + return -error;
> + }
> +
> d_tmpfile(dentry, inode);
>
I'd really love to hear from the LSM people who they plan to deal with
O_TMPFILE inodes. But given that this seems to fix a real life bug
let's go with it for now.
|
| Previous by Date: | Re: [PATCH v3 1/4] xfs: fix tmpfile/selinux ilock deadlock, Christoph Hellwig |
|---|---|
| Next by Date: | Re: [PATCH v3 3/4] xfs: replace on-stack xfs_trans_res with pointer in xfs_create(), Christoph Hellwig |
| Previous by Thread: | [PATCH v3 2/4] xfs: initialize inode security on tmpfile creation, Brian Foster |
| Next by Thread: | Re: [PATCH v3 2/4] xfs: initialize inode security on tmpfile creation, Stephen Smalley |
| Indexes: | [Date] [Thread] [Top] [All Lists] |