Re: [PATCH 3/6] xfs: xfs_vm_write_end truncates too much on failure

[Dave Chinner <david@xxxxxxxxxxxxx>]

On Thu, Apr 10, 2014 at 03:35:55AM -0700, Christoph Hellwig wrote:
> On Thu, Apr 10, 2014 at 03:00:50PM +1000, Dave Chinner wrote:
> > From: Dave Chinner <dchinner@xxxxxxxxxx>
> > 
> > Similar to the write_begin problem, xfs-vm_write_end will truncate
> > back to the old EOF, potentially removing page cache from over the
> > top of delalloc blocks with valid data in them. Fix this by
> > truncating back to just the start of the failed write.
> > 
> > Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> Looks good,
> 
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>
> 
> Any reason you used max_t in the previous one, and opencode it here?

No, just made the changes at different times. I'll fix them both to
use max_t....

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx