| To: | Dave Chinner <david@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 2/9] xfs: split xfs_bmap_btalloc_nullfb |
| From: | Christoph Hellwig <hch@xxxxxx> |
| Date: | Mon, 14 Apr 2014 09:03:25 +0200 |
| Cc: | xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20140414015544.GH27694@dastard> |
| References: | <1397289723-26243-1-git-send-email-hch@xxxxxx> <1397289723-26243-3-git-send-email-hch@xxxxxx> <20140414015544.GH27694@dastard> |
| User-agent: | Mutt/1.5.17 (2007-11-01) |
On Mon, Apr 14, 2014 at 11:55:44AM +1000, Dave Chinner wrote: > > +static void > > +xfs_bmap_fix_args( > > + struct xfs_bmalloca *ap, > > + struct xfs_alloc_arg *args, > > + xfs_extlen_t *blen, > > + int notinit) > > Not a big fan of the "fix_args" name here. What it's actually doing > is setting the minimum allocation length. Also, it could return the > minimum length rather than set it inside the function, and pass > blen by value rather than reference as it isn't modified in the > function... Sure. A any good suggestion for a name? |
| Previous by Date: | san pham danh bong - kep dinh vi, banhcuoc5b@xxxxxxxxx |
|---|---|
| Next by Date: | [ANNOUNCE] xfsprogs: v3.2.0-rc1 tagged, Dave Chinner |
| Previous by Thread: | Re: [PATCH 2/9] xfs: split xfs_bmap_btalloc_nullfb, Dave Chinner |
| Next by Thread: | Re: [PATCH 2/9] xfs: split xfs_bmap_btalloc_nullfb, Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |