| To: | Lukas Czerner <lczerner@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 2/4] fs: Prevent doing FALLOC_FL_ZERO_RANGE on append only file |
| From: | Theodore Ts'o <tytso@xxxxxxx> |
| Date: | Sat, 12 Apr 2014 09:49:05 -0400 |
| Cc: | linux-fsdevel@xxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, ceph-devel@xxxxxxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| Dkim-signature: | v=1; a=rsa-sha256; c=simple/simple; d=thunk.org; s=mail; t=1397310546; bh=JQrv2IZSXHeu524ryqUTt0/fzIW+3k2sKWLe//MyaQw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gq1246khQ+cW2i/9CSmB5PhJAw55/UXTJYYrqOaVvUL0rsaF2ATsNDO0uEahp2Uc8 +mNblMwCpJxJSqAMcLJCuvA+NfdcxooASh6T+ilsLZhCC2aJ+fouRtX/dJ5r5LTHeE Eog6eO3mPBNLzW52aca7oC19yxELtkMUewEIiSbM= |
| In-reply-to: | <1397242665-2183-2-git-send-email-lczerner@xxxxxxxxxx> |
| References: | <1397242665-2183-1-git-send-email-lczerner@xxxxxxxxxx> <1397242665-2183-2-git-send-email-lczerner@xxxxxxxxxx> |
| User-agent: | Mutt/1.5.23 (2014-03-12) |
On Fri, Apr 11, 2014 at 08:57:43PM +0200, Lukas Czerner wrote:
> Currently punch hole and collapse range fallocate operation are not
> allowed on append only file. This should be case for zero range as well.
> Fix it.
>
> Signed-off-by: Lukas Czerner <lczerner@xxxxxxxxxx>
Looks good to me. If people don't object, I'll carry this in the ext4
tree for merging in 3.15, since this is a bug fix...
- Ted
|
| Previous by Date: | Re: [PATCH 1/4] ext4: Remove unnecessary check for APPEND and IMMUTABLE, Theodore Ts'o |
|---|---|
| Next by Date: | Re: [PATCH 3/4] fs: Remove i_size check from do_fallocate, Theodore Ts'o |
| Previous by Thread: | [PATCH 2/4] fs: Prevent doing FALLOC_FL_ZERO_RANGE on append only file, Lukas Czerner |
| Next by Thread: | Re: [PATCH 2/4] fs: Prevent doing FALLOC_FL_ZERO_RANGE on append only file, Christoph Hellwig |
| Indexes: | [Date] [Thread] [Top] [All Lists] |