Re: [PATCH 4/6] xfs: zeroing space needs to punch delalloc blocks

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 4/6] xfs: zeroing space needs to punch delalloc blocks
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Thu, 10 Apr 2014 05:33:32 -0700
Cc:	Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
Delivered-to:	xfs@xxxxxxxxxxx
In-reply-to:	<20140410122259.GC27519@dastard>
References:	<1397106053-7489-1-git-send-email-david@xxxxxxxxxxxxx> <1397106053-7489-5-git-send-email-david@xxxxxxxxxxxxx> <20140410104001.GG17641@xxxxxxxxxxxxx> <20140410122259.GC27519@dastard>
User-agent:	Mutt/1.5.21 (2010-09-15)

On Thu, Apr 10, 2014 at 10:22:59PM +1000, Dave Chinner wrote:
> XFS_B_TO_FSB gives the same result given that we've already rounded
> start_boundary to block granularity....

It does, but XFS_B_TO_FSBT is one less operation, and it's the better
example for a start offset when people start copy & pasting it.

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 0/6 v2] xfs: delalloc, dio and corruption..., Dave Chinner [PATCH 1/6] xfs: kill buffers over failed write ranges properly, Dave Chinner Re: [PATCH 1/6] xfs: kill buffers over failed write ranges properly, Christoph Hellwig [PATCH 6/6] xfs: collapse range is delalloc challenged., Dave Chinner Re: [PATCH 6/6] xfs: collapse range is delalloc challenged., Christoph Hellwig [PATCH 4/6] xfs: zeroing space needs to punch delalloc blocks, Dave Chinner Re: [PATCH 4/6] xfs: zeroing space needs to punch delalloc blocks, Christoph Hellwig Re: [PATCH 4/6] xfs: zeroing space needs to punch delalloc blocks, Dave Chinner Re: [PATCH 4/6] xfs: zeroing space needs to punch delalloc blocks, Christoph Hellwig <= Re: [PATCH 4/6] xfs: zeroing space needs to punch delalloc blocks, Dave Chinner Re: [PATCH 4/6] xfs: zeroing space needs to punch delalloc blocks, Christoph Hellwig [PATCH 2/6] xfs: write failure beyond EOF truncates too much data, Dave Chinner Re: [PATCH 2/6] xfs: write failure beyond EOF truncates too much data, Christoph Hellwig [PATCH 5/6] xfs: don't map ranges that span EOF for direct IO, Dave Chinner Re: [PATCH 5/6] xfs: don't map ranges that span EOF for direct IO, Christoph Hellwig [PATCH 3/6] xfs: xfs_vm_write_end truncates too much on failure, Dave Chinner Re: [PATCH 3/6] xfs: xfs_vm_write_end truncates too much on failure, Christoph Hellwig Re: [PATCH 3/6] xfs: xfs_vm_write_end truncates too much on failure, Dave Chinner Re: [PATCH 0/6 v2] xfs: delalloc, dio and corruption..., Brian Foster

Previous by Date:	Re: [PATCH v2 1/2] xfs: fix tmpfile/selinux deadlock and initialize security/acl, Brian Foster
Next by Date:	Re: [PATCH] xfs: fix tmpfile/selinux deadlock and initialize security, Christoph Hellwig
Previous by Thread:	Re: [PATCH 4/6] xfs: zeroing space needs to punch delalloc blocks, Dave Chinner
Next by Thread:	Re: [PATCH 4/6] xfs: zeroing space needs to punch delalloc blocks, Dave Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]