| To: | Brian Foster <bfoster@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 2/2] remove ancient sys_getdents code paths |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Tue, 25 Mar 2014 08:34:22 -0700 |
| Cc: | Kyle McMartin <kmcmarti@xxxxxxxxxx>, xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20140325141553.GB18691@xxxxxxxxxxxxxxx> |
| References: | <20140324181920.GG23291@xxxxxxxxxxxxxxxxxxxxxxx> <20140325141553.GB18691@xxxxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Tue, Mar 25, 2014 at 10:15:55AM -0400, Brian Foster wrote: > I wonder if we could clean up the d_name offset checks to check it once > and use a flag. Or use a signed type for size_diff and trigger off that. > Just a thought, fwiw. I'd just leave the code as-is and just remove the ifdef cruft. If anyone is motivated enough to do real work on this area the callers should simply be switched to readdir(3) and friends instead of bikeshedding the current cruft. I just don't want to put even more load on Kyle how just wants to get xfsdump running on arm64.. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 2/2] remove ancient sys_getdents code paths, Brian Foster |
|---|---|
| Next by Date: | Re: [PATCH] xfs: fix buffer use after free on IO error, Eric Sandeen |
| Previous by Thread: | Re: [PATCH 2/2] remove ancient sys_getdents code paths, Brian Foster |
| Next by Thread: | Re: [PATCH 2/2] remove ancient sys_getdents code paths, Kyle McMartin |
| Indexes: | [Date] [Thread] [Top] [All Lists] |