| To: | Lukas Czerner <lczerner@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH v2 2/8] xfstests: create _test_block_boundaries in common/punch |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Thu, 6 Mar 2014 09:45:41 -0800 |
| Cc: | linux-ext4@xxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1394034699-21187-3-git-send-email-lczerner@xxxxxxxxxx> |
| References: | <1394034699-21187-1-git-send-email-lczerner@xxxxxxxxxx> <1394034699-21187-3-git-send-email-lczerner@xxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
Looks good, but having a comment explaining the function would be helpful given that the name isn't entirely self-describing. Reviewed-by: Christoph Hellwig <hch@xxxxxx> |
| Previous by Date: | Re: [PATCH v2 1/8] xfstests: Create single function for testing xfs_io commands, Christoph Hellwig |
|---|---|
| Next by Date: | Re: [PATCH v2 3/8] generic/008: Add test for fallocate zero range at block boundary, Christoph Hellwig |
| Previous by Thread: | [PATCH v2 2/8] xfstests: create _test_block_boundaries in common/punch, Lukas Czerner |
| Next by Thread: | [PATCH v2 3/8] generic/008: Add test for fallocate zero range at block boundary, Lukas Czerner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |