Re: [PATCH 2/2] xfs: inode log reservations are still too small

xfs

Re: [PATCH 2/2] xfs: inode log reservations are still too small

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 2/2] xfs: inode log reservations are still too small
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Wed, 5 Mar 2014 14:34:28 -0800
Cc:	Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
Delivered-to:	xfs@xxxxxxxxxxx
In-reply-to:	<20140305214002.GI6851@dastard>
References:	<1393981893-2497-1-git-send-email-david@xxxxxxxxxxxxx> <1393981893-2497-3-git-send-email-david@xxxxxxxxxxxxx> <20140305171441.GD11667@xxxxxxxxxxxxx> <20140305214002.GI6851@dastard>
User-agent:	Mutt/1.5.21 (2010-09-15)

> We don't. We need to, I just haven't had the time to audit the rest
> of the reservations to fix them all up yet. AFAIA, only the quota
> off transactions don't have any slack in them for xlog_op_header
> space - all the others that are incorrect probably have enough
> overhead from the buffer overhead roundup to cover the lack ophdr
> accounting on things like dquots.

That's more or less what I expected..

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 0/2] xfs: more bug fixes, Dave Chinner [PATCH 2/2] xfs: inode log reservations are still too small, Dave Chinner Re: [PATCH 2/2] xfs: inode log reservations are still too small, Eric Sandeen Re: [PATCH 2/2] xfs: inode log reservations are still too small, Christoph Hellwig Re: [PATCH 2/2] xfs: inode log reservations are still too small, Dave Chinner Re: [PATCH 2/2] xfs: inode log reservations are still too small, Christoph Hellwig <= Re: [PATCH 2/2] xfs: inode log reservations are still too small, Brian Foster [PATCH 1/2] xfs: xfs_check_page_type buffer checks need help, Dave Chinner Re: [PATCH 1/2] xfs: xfs_check_page_type buffer checks need help, Christoph Hellwig Re: [PATCH 1/2] xfs: xfs_check_page_type buffer checks need help, Brian Foster Re: [PATCH 1/2] xfs: xfs_check_page_type buffer checks need help, Dave Chinner

Previous by Date:	Re: [PATCH 1/2] xfs: xfs_check_page_type buffer checks need help, Brian Foster
Next by Date:	Re: [PATCH] xfsprogs: fix use after free in inode_item_done(), Eric Sandeen
Previous by Thread:	Re: [PATCH 2/2] xfs: inode log reservations are still too small, Dave Chinner
Next by Thread:	Re: [PATCH 2/2] xfs: inode log reservations are still too small, Brian Foster
Indexes:	[Date] [Thread] [Top] [All Lists]