xfs
[Top] [All Lists]
<prev [Date] next>
[Advanced]
 <prev [Thread] next>

Re: [PATCH 1/2] xfs: xfs_check_page_type buffer checks need help

from [Christoph Hellwig] [Permanent Link][Original]
To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 1/2] xfs: xfs_check_page_type buffer checks need help
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 5 Mar 2014 09:06:32 -0800
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1393981893-2497-2-git-send-email-david@xxxxxxxxxxxxx>
References: <1393981893-2497-1-git-send-email-david@xxxxxxxxxxxxx> <1393981893-2497-2-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15) 
This looks correct, but why don't we simply have a special cased
function looking or any delalloc page for xfs_aops_discard_page instead
of having one that is fairly over-general?

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

if you want to go down this route anyway.
[More with this subject...]
<Prev in Thread] Current Thread [Next in Thread>
Previous by Date:  Re: [PATCH] xfsprogs: fix use after free in inode_item_done(), Christoph Hellwig
Next by Date:  Re: [PATCH 2/2] xfs: inode log reservations are still too small, Christoph Hellwig
Previous by Thread:  [PATCH 1/2] xfs: xfs_check_page_type buffer checks need help, Dave Chinner
Next by Thread:  Re: [PATCH 1/2] xfs: xfs_check_page_type buffer checks need help, Brian Foster
Indexes:  [Date] [Thread] [Top] [All Lists]