| To: | Eric Sandeen <sandeen@xxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 3/3] metadump: pathname obfuscation overruns symlink buffer |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Sat, 1 Mar 2014 10:28:16 +1100 |
| Cc: | xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <5310CAEB.8080503@xxxxxxxxxxx> |
| References: | <1393568723-982-1-git-send-email-david@xxxxxxxxxxxxx> <1393568723-982-4-git-send-email-david@xxxxxxxxxxxxx> <5310CAEB.8080503@xxxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Fri, Feb 28, 2014 at 11:44:11AM -0600, Eric Sandeen wrote: > On 2/28/14, 12:25 AM, Dave Chinner wrote: > > diff --git a/db/metadump.c b/db/metadump.c > > index 3248009..cd489a6 100644 > > --- a/db/metadump.c > > +++ b/db/metadump.c > > @@ -1015,16 +1015,23 @@ obfuscate_sf_dir( > > } > > } > > > > +/* > > + * The pathname may not be null terminated. It name be terminated by the > > end of > > can you fix up the start of that 2nd sentence? Done. > > Otherwise, > > Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxx> Thanks! Dave. -- Dave Chinner david@xxxxxxxxxxxxx |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 4/8] xfstests: Move fallocate include into global.h, Dave Chinner |
|---|---|
| Previous by Thread: | Re: [PATCH 3/3] metadump: pathname obfuscation overruns symlink buffer, Eric Sandeen |
| Next by Thread: | [PATCH 2/3] metadump: Only verify obfuscated metadata being dumped, Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |