| To: | Eric Sandeen <sandeen@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] xfs_growfs: don't grow data if only -m is specified |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Fri, 28 Feb 2014 12:19:01 +1100 |
| Cc: | xfs-oss <xfs@xxxxxxxxxxx> |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <530FCA2C.8090204@xxxxxxxxxx> |
| References: | <530FCA2C.8090204@xxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Thu, Feb 27, 2014 at 05:28:44PM -0600, Eric Sandeen wrote: > While writing an xfstest to check imaxpct behavior, I realized > that xfs_growfs -m XXX /mnt/point will not only change > imaxpct, but also grow the filesystem if it's not currently > occupying the entire block device. This doesn't seem like > the expected behavior, so split it out such that if only > -m, and not -d, is specified, only the imaxpct will be > changed. > > This is a change from previous behavior, but I think it > satisfies the principle of least surprise... Seems reasonable to me. Code looks good, too. Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx> -- Dave Chinner david@xxxxxxxxxxxxx |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 1/2] mkfs: default log size for small filesystems too large, Dave Chinner |
|---|---|
| Next by Date: | Re: [PATCH] metadump: don't verify metadata being dumped, Eric Sandeen |
| Previous by Thread: | [PATCH] xfs_growfs: don't grow data if only -m is specified, Eric Sandeen |
| Next by Thread: | [PATCH] metadump: don't verify metadata being dumped, Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |