| To: | Eric Sandeen <sandeen@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 5/9] xfs: add helper for verifying checksums on xfs_bufs |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Thu, 27 Feb 2014 15:17:22 +1100 |
| Cc: | xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1392767549-25574-6-git-send-email-sandeen@xxxxxxxxxx> |
| References: | <1392767549-25574-1-git-send-email-sandeen@xxxxxxxxxx> <1392767549-25574-6-git-send-email-sandeen@xxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Tue, Feb 18, 2014 at 05:52:25PM -0600, Eric Sandeen wrote: > Many/most callers of xfs_verify_cksum() pass bp->b_addr and > BBTOB(bp->b_length) as the first 2 args. Add a helper > which can just accept the bp and the crc offset, and work > it out on its own, for brevity. > > Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx> Looks good. Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx> -- Dave Chinner david@xxxxxxxxxxxxx |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH v6] ext4: Add support FALLOC_FL_COLLAPSE_RANGE for fallocate, Namjae Jeon |
|---|---|
| Next by Date: | Re: [PATCH 7/9 V2] xfs: add xfs_verifier_error(), Dave Chinner |
| Previous by Thread: | [PATCH 5/9] xfs: add helper for verifying checksums on xfs_bufs, Eric Sandeen |
| Next by Thread: | [PATCH 9/9] xfs: modify verifiers to differentiate CRC from other errors, Eric Sandeen |
| Indexes: | [Date] [Thread] [Top] [All Lists] |