| To: | Dave Chinner <david@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 08/10] libxfs: remove a couple of locks |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Tue, 25 Feb 2014 17:54:32 -0800 |
| Cc: | xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20140225234357.GJ13647@dastard> |
| References: | <1393223369-4696-1-git-send-email-david@xxxxxxxxxxxxx> <1393223369-4696-9-git-send-email-david@xxxxxxxxxxxxx> <20140225200558.GC22351@xxxxxxxxxxxxx> <20140225234357.GJ13647@dastard> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Wed, Feb 26, 2014 at 10:43:57AM +1100, Dave Chinner wrote: > On Tue, Feb 25, 2014 at 12:05:58PM -0800, Christoph Hellwig wrote: > > So what's protecting the cache hits statistics now? > > Nothing. And I don't care because the statistic is meaningless from > the point of view of tuning xfs_repair performance. In that case I think it's better to just remove c_hits instead of updating it in a racy way. |
| Previous by Date: | Re: [PATCH 07/10] repair: prefetch runs too far ahead, Christoph Hellwig |
|---|---|
| Next by Date: | Re: [PATCH v5 1/10] fs: Add new flag(FALLOC_FL_COLLAPSE_RANGE) for fallocate, Dave Chinner |
| Previous by Thread: | Re: [PATCH 08/10] libxfs: remove a couple of locks, Dave Chinner |
| Next by Thread: | Re: [PATCH 08/10] libxfs: remove a couple of locks, Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |