| To: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 10/10] repair: BMBT prefetch needs to be CRC aware |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Wed, 26 Feb 2014 10:51:12 +1100 |
| Cc: | xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20140225172518.GA12871@xxxxxxxxxxxxx> |
| References: | <1393223369-4696-1-git-send-email-david@xxxxxxxxxxxxx> <1393223369-4696-11-git-send-email-david@xxxxxxxxxxxxx> <20140225172518.GA12871@xxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Tue, Feb 25, 2014 at 09:25:18AM -0800, Christoph Hellwig wrote: > > /* > > * do some validation on the block contents > > */ > > - if ((be32_to_cpu(block->bb_magic) != XFS_BMAP_MAGIC) || > > + if ((block->bb_magic != cpu_to_be32(XFS_BMAP_MAGIC) && > > + block->bb_magic != cpu_to_be32(XFS_BMAP_CRC_MAGIC)) || > > (be16_to_cpu(block->bb_level) != level)) > > Seems like this should be factored into a well-documented helper > function. Sure, but it's way outside the scope of fixing this bug. We'd need to start with the kernel code, then port it is userspace and propagate it into all the utilities. Patches welcome ;) Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx |
| Previous by Date: | Re: [PATCH 08/10] libxfs: remove a couple of locks, Dave Chinner |
|---|---|
| Next by Date: | Re: [PATCH v2] xfstests: add test for btrfs-progs restore feature, Filipe David Manana |
| Previous by Thread: | Re: [PATCH 10/10] repair: BMBT prefetch needs to be CRC aware, Christoph Hellwig |
| Next by Thread: | Re: [PATCH 10/10] repair: BMBT prefetch needs to be CRC aware, Christoph Hellwig |
| Indexes: | [Date] [Thread] [Top] [All Lists] |