Re: [PATCH 10/10] repair: BMBT prefetch needs to be CRC aware

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 10/10] repair: BMBT prefetch needs to be CRC aware
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Tue, 25 Feb 2014 09:25:18 -0800
Cc:	xfs@xxxxxxxxxxx
Delivered-to:	xfs@xxxxxxxxxxx
In-reply-to:	<1393223369-4696-11-git-send-email-david@xxxxxxxxxxxxx>
References:	<1393223369-4696-1-git-send-email-david@xxxxxxxxxxxxx> <1393223369-4696-11-git-send-email-david@xxxxxxxxxxxxx>
User-agent:	Mutt/1.5.21 (2010-09-15)

>       /*
>        * do some validation on the block contents
>        */
> -     if ((be32_to_cpu(block->bb_magic) != XFS_BMAP_MAGIC) ||
> +     if ((block->bb_magic != cpu_to_be32(XFS_BMAP_MAGIC) &&
> +          block->bb_magic != cpu_to_be32(XFS_BMAP_CRC_MAGIC)) ||
>                       (be16_to_cpu(block->bb_level) != level))

Seems like this should be factored into a well-documented helper
function.

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 00/10, v2] repair: scalability and prefetch fixes, Dave Chinner [PATCH 02/10] repair: per AG locks contend for cachelines, Dave Chinner [PATCH 08/10] libxfs: remove a couple of locks, Dave Chinner Re: [PATCH 08/10] libxfs: remove a couple of locks, Christoph Hellwig Re: [PATCH 08/10] libxfs: remove a couple of locks, Dave Chinner Re: [PATCH 08/10] libxfs: remove a couple of locks, Christoph Hellwig Re: [PATCH 08/10] libxfs: remove a couple of locks, Dave Chinner [PATCH 10/10] repair: BMBT prefetch needs to be CRC aware, Dave Chinner Re: [PATCH 10/10] repair: BMBT prefetch needs to be CRC aware, Christoph Hellwig <= Re: [PATCH 10/10] repair: BMBT prefetch needs to be CRC aware, Dave Chinner Re: [PATCH 10/10] repair: BMBT prefetch needs to be CRC aware, Christoph Hellwig Re: [PATCH 10/10] repair: BMBT prefetch needs to be CRC aware, Christoph Hellwig [PATCH 07/10] repair: prefetch runs too far ahead, Dave Chinner Re: [PATCH 07/10] repair: prefetch runs too far ahead, Christoph Hellwig Re: [PATCH 07/10] repair: prefetch runs too far ahead, Dave Chinner [PATCH 06/10] repair: use a listhead for the dotdot list, Dave Chinner Re: [PATCH 06/10] repair: use a listhead for the dotdot list, Christoph Hellwig Re: [PATCH 06/10] repair: use a listhead for the dotdot list, Dave Chinner [PATCH 03/10] libxfs: buffer cache hashing is suboptimal, Dave Chinner

Previous by Date:	Re: Question regarding XFS on LVM over hardware RAID., Emmanuel Florac
Next by Date:	Re: [PATCH] xfs_metadump: include F in getopts string, Mark Tinguely
Previous by Thread:	[PATCH 10/10] repair: BMBT prefetch needs to be CRC aware, Dave Chinner
Next by Thread:	Re: [PATCH 10/10] repair: BMBT prefetch needs to be CRC aware, Dave Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]