| To: | Dave Chinner <david@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] xfs/189: noattr2 invalid for CRC enabled filesystems |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Mon, 10 Feb 2014 02:45:14 -0800 |
| Cc: | Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20140210015200.GO13647@dastard> |
| References: | <1391590000-7171-1-git-send-email-david@xxxxxxxxxxxxx> <20140207174754.GA31464@xxxxxxxxxxxxx> <20140210015200.GO13647@dastard> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Mon, Feb 10, 2014 at 12:52:00PM +1100, Dave Chinner wrote: > > I really don't like opencoding this. Shouldn't we instead simplfy > > pass a nocrc argument to _scratch_mkfs_xfs? > > No, that simply breaks old mkfs binaries. Well, we couldn't pass it unconditionally - the main idea is to hide the magic and allow tests to easily create a noncrc filesystem. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] xfs/033: add golden output for CRC enaled filesystems, Christoph Hellwig |
|---|---|
| Next by Date: | Re: [PATCH] xfs/033: add golden output for CRC enaled filesystems, Dave Chinner |
| Previous by Thread: | Re: [PATCH] xfs/189: noattr2 invalid for CRC enabled filesystems, Dave Chinner |
| Next by Thread: | [PATCH 0/2] __btrfs_drop_extents() BUG_ON reproducer, David Disseldorp |
| Indexes: | [Date] [Thread] [Top] [All Lists] |